[1.18] Azure appconfig - include contentType and label in metadata#4338
Draft
MyMirelHub wants to merge 2 commits intodapr:mainfrom
Draft
[1.18] Azure appconfig - include contentType and label in metadata#4338MyMirelHub wants to merge 2 commits intodapr:mainfrom
MyMirelHub wants to merge 2 commits intodapr:mainfrom
Conversation
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure App Configuration configuration store to surface additional Azure setting properties in the returned configuration.Item.Metadata, and adds unit test assertions to validate those metadata fields.
Changes:
- Refactors setting →
configuration.Itemconversion into a helper (settingToConfigurationItem). - Adds
contentType(and validateslabel) to returned item metadata. - Updates mocks and tests to populate/assert
LabelandContentType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| configuration/azure/appconfig/appconfig.go | Centralizes mapping logic and adds contentType to response metadata. |
| configuration/azure/appconfig/appconfig_test.go | Extends mock settings and adds assertions for label/contentType metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Azure App Configuration configuration store to surface additional Azure setting properties in the returned
configuration.Item.Metadata, and adds unit test assertions to validate those metadata fields.Changes:
configuration.Itemconversion into a helper (settingToConfigurationItem).contentType(and validateslabel) to returned item metadata.LabelandContentType.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #4308
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.